[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 3/6] pc: Abort if HotplugHandlerClass::plug() fails
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [PULL 3/6] pc: Abort if HotplugHandlerClass::plug() fails |
Date: |
Fri, 3 Jul 2015 17:50:21 -0300 |
From: Bharata B Rao <address@hidden>
HotplugHandlerClass::plug() shouldn't fail and hence use error_abort
to abort if it fails.
Signed-off-by: Bharata B Rao <address@hidden>
Reviewed-by: David Gibson <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Tested-by: Igor Mammedov <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
---
hw/i386/pc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 8df1f3e..a66416d 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1577,7 +1577,7 @@ static void pc_dimm_plug(HotplugHandler *hotplug_dev,
}
hhc = HOTPLUG_HANDLER_GET_CLASS(pcms->acpi_dev);
- hhc->plug(HOTPLUG_HANDLER(pcms->acpi_dev), dev, &local_err);
+ hhc->plug(HOTPLUG_HANDLER(pcms->acpi_dev), dev, &error_abort);
out:
error_propagate(errp, local_err);
}
--
2.1.0
- [Qemu-devel] [PULL 0/6] NUMA queue, 2015-07-03, Eduardo Habkost, 2015/07/03
- [Qemu-devel] [PULL 1/6] pc, pc-dimm: Extract hotplug related fields in PCMachineState to a structure, Eduardo Habkost, 2015/07/03
- [Qemu-devel] [PULL 2/6] pc, pc-dimm: Factor out reusable parts in pc_dimm_plug to a separate routine, Eduardo Habkost, 2015/07/03
- [Qemu-devel] [PULL 3/6] pc: Abort if HotplugHandlerClass::plug() fails,
Eduardo Habkost <=
- [Qemu-devel] [PULL 4/6] numa, pc-dimm: Store pc-dimm memory information in numa_info, Eduardo Habkost, 2015/07/03
- [Qemu-devel] [PULL 6/6] numa: API to lookup NUMA node by address, Eduardo Habkost, 2015/07/03
- [Qemu-devel] [PULL 5/6] numa: Store boot memory address range in node_info, Eduardo Habkost, 2015/07/03
- Re: [Qemu-devel] [PULL 0/6] NUMA queue, 2015-07-03, Peter Maydell, 2015/07/05