[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4] arm_mptimer: Respect IT bit state
From: |
Dmitry Osipenko |
Subject: |
[Qemu-devel] [PATCH v4] arm_mptimer: Respect IT bit state |
Date: |
Mon, 6 Jul 2015 04:27:12 +0300 |
The timer should fire the interrupt only if the IT (interrupt enable) bit
state of the control register is enabled.
Signed-off-by: Dmitry Osipenko <address@hidden>
Reviewed-by: Peter Crosthwaite <address@hidden>
---
v2: Added missed IRQ status update on control register write as per
Peter Crosthwaite comment.
v3: No code change, just re-send.
v4: Revert to v1, as it was correct, with a slightly change commit message.
hw/timer/arm_mptimer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/timer/arm_mptimer.c b/hw/timer/arm_mptimer.c
index 0e132b1..3e59c2a 100644
--- a/hw/timer/arm_mptimer.c
+++ b/hw/timer/arm_mptimer.c
@@ -38,7 +38,7 @@ static inline int get_current_cpu(ARMMPTimerState *s)
static inline void timerblock_update_irq(TimerBlock *tb)
{
- qemu_set_irq(tb->irq, tb->status);
+ qemu_set_irq(tb->irq, tb->status && (tb->control & 4));
}
/* Return conversion factor from mpcore timer ticks to qemu timer ticks. */
--
2.4.4
- Re: [Qemu-devel] [PATCH 1/2] arm_mptimer: Fix timer shutdown and mode change, (continued)
- [Qemu-devel] [PATCH v3 0/2] arm_mptimer fixes, Dmitry Osipenko, 2015/07/05
- [Qemu-devel] [PATCH v2 1/2] arm_mptimer: Fix timer shutdown and mode change, Dmitry Osipenko, 2015/07/05
- [Qemu-devel] [PATCH v3 2/2] arm_mptimer: Respect IT bit state, Dmitry Osipenko, 2015/07/05
- Re: [Qemu-devel] [PATCH v3 2/2] arm_mptimer: Respect IT bit state, Dmitry Osipenko, 2015/07/05
- [Qemu-devel] [PATCH v4] arm_mptimer: Respect IT bit state,
Dmitry Osipenko <=
- Re: [Qemu-devel] [PATCH v4] arm_mptimer: Respect IT bit state, Peter Maydell, 2015/07/06
- Re: [Qemu-devel] [PATCH v4] arm_mptimer: Respect IT bit state, Dmitry Osipenko, 2015/07/06
- Re: [Qemu-devel] [PATCH v4] arm_mptimer: Respect IT bit state, Peter Maydell, 2015/07/06
- Re: [Qemu-devel] [PATCH v4] arm_mptimer: Respect IT bit state, Dmitry Osipenko, 2015/07/06
- Re: [Qemu-devel] [PATCH v4] arm_mptimer: Respect IT bit state, Peter Crosthwaite, 2015/07/06
- Re: [Qemu-devel] [PATCH v4] arm_mptimer: Respect IT bit state, Dmitry Osipenko, 2015/07/06