Re: [Qemu-devel] [PATCH v5 10/11] target-i386: remove useless PC updates

[Aurelien Jarno]

On 2015-07-06 11:26, Pavel Dovgalyuk wrote:
> This patch removes useless PC updates before executing instructions.
> PC can be recovered with correct exception handling by using TB return 
> address.
> 
> Signed-off-by: Pavel Dovgalyuk <address@hidden>
> ---
>  target-i386/translate.c |   25 -------------------------
>  1 files changed, 0 insertions(+), 25 deletions(-)

This would be a lot easier to review, if each of this change is 
actually moved to the corresponding patch passing retaddr to the
exception function. In addition to that you have left a few call to
gen_update_cc_op(s). They are not needed if the helper doesn't read
not write cc_op.

Finally, this patch misses at least helper_fbld_ST0.

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
address@hidden                 http://www.aurel32.net