[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 05/11] target-i386: exception handling for FP
From: |
Pavel Dovgaluk |
Subject: |
Re: [Qemu-devel] [PATCH v5 05/11] target-i386: exception handling for FPU instructions |
Date: |
Mon, 6 Jul 2015 15:42:58 +0300 |
> From: Richard Henderson [mailto:address@hidden On Behalf Of Richard Henderson
> On 07/06/2015 09:26 AM, Pavel Dovgalyuk wrote:
> > @@ -1117,33 +1131,33 @@ void helper_fxsave(CPUX86State *env, target_ulong
> > ptr, int data64)
> > for (i = 0; i < 8; i++) {
> > fptag |= (env->fptags[i] << i);
> > }
> > - cpu_stw_data(env, ptr, env->fpuc);
> > - cpu_stw_data(env, ptr + 2, fpus);
> > - cpu_stw_data(env, ptr + 4, fptag ^ 0xff);
> > + cpu_stw_data_ra(env, ptr, env->fpuc, GETPC());
> > + cpu_stw_data_ra(env, ptr + 2, fpus, GETPC());
> > + cpu_stw_data_ra(env, ptr + 4, fptag ^ 0xff, GETPC());
>
> helper_fxsave and helper_fxrstor ought to have do_* versions just like you did
> for fstenv/fldenv. (I'm working on a patch set that adds xsave/xrstor support
> and I'll need to re-use these functions.)
Why do_* functions should be in this series?
These changes will look orphaned.
Pavel Dovgalyuk
- [Qemu-devel] [PATCH v5 00/11] Fix exceptions handling for MIPS, PowerPC, and i386, Pavel Dovgalyuk, 2015/07/06
- [Qemu-devel] [PATCH v5 01/11] softmmu: add helper function to pass through retaddr, Pavel Dovgalyuk, 2015/07/06
- [Qemu-devel] [PATCH v5 02/11] cpu-exec: introduce loop exit with restore function, Pavel Dovgalyuk, 2015/07/06
- [Qemu-devel] [PATCH v5 04/11] target-i386: introduce new raise_exception functions, Pavel Dovgalyuk, 2015/07/06
- [Qemu-devel] [PATCH v5 05/11] target-i386: exception handling for FPU instructions, Pavel Dovgalyuk, 2015/07/06
- Re: [Qemu-devel] [PATCH v5 05/11] target-i386: exception handling for FPU instructions, Aurelien Jarno, 2015/07/06
- [Qemu-devel] [PATCH v5 03/11] target-mips: improve exceptions handling, Pavel Dovgalyuk, 2015/07/06
- [Qemu-devel] [PATCH v5 06/11] target-i386: exception handling for div instructions, Pavel Dovgalyuk, 2015/07/06
- [Qemu-devel] [PATCH v5 07/11] target-i386: exception handling for memory helpers, Pavel Dovgalyuk, 2015/07/06