[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 12/12] i386/kvm: Hyper-v crash msrs set/get'ers
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 12/12] i386/kvm: Hyper-v crash msrs set/get'ers and migration |
|
Date: |
Tue, 7 Jul 2015 12:21:48 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 |
On 03/07/2015 14:01, Denis V. Lunev wrote:
> @@ -904,6 +905,7 @@ typedef struct CPUX86State {
> uint64_t msr_hv_guest_os_id;
> uint64_t msr_hv_vapic;
> uint64_t msr_hv_tsc;
> + uint64_t msr_hv_crash_prm[HV_X64_MSR_CRASH_PARAMS];
Do not abbreviate variable names! The enum even says PARAMS, so use
params in the array name as well.
I've done the change locally in all files.
Paolo
> /* exception/interrupt handling */
> int error_code;
- [Qemu-devel] [PATCH 6/12] kvm/x86: mark hyper-v crash msrs as partition wide, (continued)
- [Qemu-devel] [PATCH 6/12] kvm/x86: mark hyper-v crash msrs as partition wide, Denis V. Lunev, 2015/07/03
- [Qemu-devel] [PATCH 10/12] kvm: Add kvm system event crash handler, Denis V. Lunev, 2015/07/03
- [Qemu-devel] [PATCH 8/12] kvm/x86: add sending hyper-v crash notification to user space, Denis V. Lunev, 2015/07/03
- [Qemu-devel] [PATCH 4/12] kvm/x86: added hyper-v crash msrs into kvm hyperv context, Denis V. Lunev, 2015/07/03
- [Qemu-devel] [PATCH 09/12] Added generic panic handler qemu_system_guest_panicked(), Denis V. Lunev, 2015/07/03
- [Qemu-devel] [PATCH 7/12] kvm/x86: added hyper-v crash data and ctl msr's get/set'ers, Denis V. Lunev, 2015/07/03
- [Qemu-devel] [PATCH 1/12] kvm/x86: move Hyper-V MSR's/hypercall code into hyperv.c file, Denis V. Lunev, 2015/07/03
- [Qemu-devel] [PATCH 11/12] cpu: Add crash_occurred flag into CPUState, Denis V. Lunev, 2015/07/03
- [Qemu-devel] [PATCH 12/12] i386/kvm: Hyper-v crash msrs set/get'ers and migration, Denis V. Lunev, 2015/07/03
- Re: [Qemu-devel] [PATCH v6 0/12] HyperV equivalent of pvpanic driver, Paolo Bonzini, 2015/07/07