[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL for-2.4 5/9] rocker: fix misplaced break statement
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PULL for-2.4 5/9] rocker: fix misplaced break statement |
Date: |
Tue, 7 Jul 2015 13:38:21 +0100 |
From: Scott Feldman <address@hidden>
Premature break in switch case block. This particular case (group L2 rewrite)
will be used for L2 LAG and L3 ECMP support, neither of which are enabled in
the guest driver at this time, but are under development.
Signed-off-by: Scott Feldman <address@hidden>
Reported-by: Paolo Bonzini <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
hw/net/rocker/rocker_of_dpa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/net/rocker/rocker_of_dpa.c b/hw/net/rocker/rocker_of_dpa.c
index b25a17d..02b3896 100644
--- a/hw/net/rocker/rocker_of_dpa.c
+++ b/hw/net/rocker/rocker_of_dpa.c
@@ -2525,7 +2525,6 @@ static void of_dpa_group_fill(void *key, void *value,
void *user_data)
ngroup->has_set_vlan_id = true;
ngroup->set_vlan_id = ntohs(group->l2_rewrite.vlan_id);
}
- break;
if (memcmp(group->l2_rewrite.src_mac.a, zero_mac.a, ETH_ALEN)) {
ngroup->has_set_eth_src = true;
ngroup->set_eth_src =
@@ -2536,6 +2535,7 @@ static void of_dpa_group_fill(void *key, void *value,
void *user_data)
ngroup->set_eth_dst =
qemu_mac_strdup_printf(group->l2_rewrite.dst_mac.a);
}
+ break;
case ROCKER_OF_DPA_GROUP_TYPE_L2_FLOOD:
case ROCKER_OF_DPA_GROUP_TYPE_L2_MCAST:
ngroup->has_vlan_id = true;
--
2.4.3
- [Qemu-devel] [PULL for-2.4 0/9] Net patches, Stefan Hajnoczi, 2015/07/07
- [Qemu-devel] [PULL for-2.4 1/9] rocker: fix memory leak, Stefan Hajnoczi, 2015/07/07
- [Qemu-devel] [PULL for-2.4 2/9] e1000: flush packets when link comes up, Stefan Hajnoczi, 2015/07/07
- [Qemu-devel] [PULL for-2.4 3/9] vmxnet3: Fix incorrect small packet padding, Stefan Hajnoczi, 2015/07/07
- [Qemu-devel] [PULL for-2.4 4/9] rocker: don't queue receive pkts when port is disabled, Stefan Hajnoczi, 2015/07/07
- [Qemu-devel] [PULL for-2.4 5/9] rocker: fix misplaced break statement,
Stefan Hajnoczi <=
- [Qemu-devel] [PULL for-2.4 6/9] rocker: fix missing break statements, Stefan Hajnoczi, 2015/07/07
- [Qemu-devel] [PULL for-2.4 7/9] rocker: return -1 when dropping packet on ingress, Stefan Hajnoczi, 2015/07/07
- [Qemu-devel] [PULL for-2.4 8/9] rocker: mark copy-to-cpu pkts as forwarding offloaded, Stefan Hajnoczi, 2015/07/07
- [Qemu-devel] [PULL for-2.4 9/9] rocker: tests: don't need to specify master/self when setting vlans, Stefan Hajnoczi, 2015/07/07
- Re: [Qemu-devel] [PULL for-2.4 0/9] Net patches, Peter Maydell, 2015/07/07