Re: [Qemu-devel] [PULL v2 00/12] Final changes for 2.4-rc0

[Peter Maydell]

On 7 July 2015 at 15:12, Paolo Bonzini <address@hidden> wrote:
> The following changes since commit f6e3035f75e5c6a73485335765ae070304c7a110:
>
>   Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream-smm' into 
> staging (2015-07-06 23:37:53 +0100)
>
> are available in the git repository at:
>
>   git://github.com/bonzini/qemu.git tags/for-upstream
>
> for you to fetch changes up to c2cf14b2d2fa7b7b5e84cc8953a804ceab89a559:
>
>   ossaudio: fix memory leak (2015-07-07 16:12:06 +0200)
>
> ----------------------------------------------------------------
> Bugfixes and Daniel Berrange's crypto library.
>
> ----------------------------------------------------------------

I'm afraid this fails to build on OSX:

/Users/pm215/src/qemu/crypto/cipher.c:36:13: warning: comparison of
unsigned enum expression < 0 is always
      false [-Wtautological-compare]
    if (alg < 0 ||
        ~~~ ^ ~
  CC    block/qcow2-refcount.o
1 warning generated.
  CC    block/qcow2-cluster.o
  CC    block/qcow2-snapshot.o
  CC    block/qcow2-cache.o
  CC    block/quorum.o
  CC    vl.o
In file included from /Users/pm215/src/qemu/block/quorum.c:27:
/sw/include/glib-2.0/glib/gi18n.h:25:10: fatal error: 'libintl.h' file not found
#include <libintl.h>
         ^
1 error generated.

and also on 32-bit ARM Linux:

/root/qemu/crypto/cipher.c: In function ‘qcrypto_cipher_validate_key_length’:
/root/qemu/crypto/cipher.c:36:5: error: comparison of unsigned
expression < 0 is always false [-Werror=type-limits]

-- PMM