Re: [Qemu-devel] [PATCH] raw-posix.c: Make physical devices usable in QEMU

[Programmingkid]

On Jul 9, 2015, at 5:35 AM, Laurent Vivier wrote:

> 
> 
> On 07/07/2015 19:33, Programmingkid wrote:
>> Make physical devices like a USB flash drive or a CDROM drive work in
>> QEMU. With
>> this patch I can use a USB flash drive like a hard drive. Before this
>> patch, 
>> QEMU would just quit with a message like "resource busy". Now it handles
>> issues
>> like these for the user. This patch unmounts volumes of physical devices
>> before
>> using them in QEMU. When QEMU quits, the physical devices are mounted again
>> for the user. The user can find out which device files to use for their
>> physical
>> devices by running the mount command in the terminal. This patch makes
>> "qemu-system-ppc -cdrom /dev/cdrom" work again on Mac OS X.
>> 
>> Signed-off-by: John Arbuckle <address@hidden
>> <mailto:address@hidden>>
> 
> Two comments:
> - you should not mix several fixes in one patch (raw block device
> management, partition seek, unmount/mount cdrom...)

I consider this patch one fix with several related changes. 

> - according to Stefan answer, I think you should not unmount the CDROM
> but you should inform the user he must unmount it manually to be able to
> use it.

Having the user unmount the CDROM manually isn't as user friendly as
having QEMU doing it for him or her.