Re: [Qemu-devel] [PATCH v5 4/6] target-arm: Add the Hypervisor timer

[Peter Maydell]

On 10 July 2015 at 12:23, Edgar E. Iglesias <address@hidden> wrote:
>
> On 10/07/2015 7:58 pm, "Peter Maydell" <address@hidden> wrote:
>> Something I just noticed while I was trying to add support
>> for the secure physical timer on top of this series: the
>> gt_*_cnt_reset functions are misnamed, because they're not
>> resetting the counters, they're resetting the timers.
>> (There are only two counters, physical and virtual, but there
>> are four timers, physical, secure-physical, virtual and hyp.
>> Since our reset function is deleting the underlying QEMU
>> timer it's a timer reset, not a counter reset.)
>> We should probably fix up the names and make sure they're
>> associated with the correct registers (the phys and virt
>> timer reset is currently hanging off a counter register)

> Hi, yes that sounds good. Btw are you fixing this as you go or should I send
> a new series fixing your comments? I've fixed the stuff you commented on a
> few days ago in my tree...

I rebased as I was reviewing it and am currently basing my
secure-timer patches on that. It would probably be good if
you fixed up the naming issue here and resent, and then I'll
rebase on top of that.

-- PMM