[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 12/62] framebuffer: check memory_region_is_loggin
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PULL 12/62] framebuffer: check memory_region_is_logging |
Date: |
Mon, 13 Jul 2015 12:15:18 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 |
On 13/07/2015 10:55, Peter Maydell wrote:
> Yes, that would make sense. But why do we need to do more
> full invalidates now?
Because the board doesn't call memory_region_set_log.
> > You can just add a memory_region_set_log call for the integratorcp and
> > versatilepb RAM regions.
>
> It seems a bit of a shame that we basically broke previously
> working configs for all our boards with embedded framebuffer
> in RAM :-(
They are not broken, just less efficient. But it's easy to fix; I'll
prepare the patch to add memory_region_set_log.
Paolo