Re: [Qemu-devel] [ARM SMBIOS RFC PATCH 0/5] SMBIOS Support for ARM

[Laszlo Ersek]

On 07/14/15 22:23, Wei Huang wrote:
> SMBIOS tables present userful system hardware info to management
> applications, such as DMI tools. Even though SMBIOS was originally
> developed for Intel x86, it has been extended to both Itanium and 
> ARM (32bit & 64bit). More and more ARM server releases, such as 
> RHEL Server for ARM, start to integrate support for SMBIOS.
> 
> This patchset is intendted to provid SMBIOS tables for ARM mach-virt
> machine. The SMBIOS tables are created and stored in fw_cfg, awaiting
> OVMF (AAVMF) to parse/present SMBIOS entry.
> 
> NOTE: This is RFC and the patches haven't been fully tested yet.
> Laszlo is kind enough to offer help on fixing AAVMF to enable support
> for SMBIOS. Any comments are welcomed for next release.

Your series is functional; I posted a matching patch set for edk2 (with
example dmidecode output in the blurb):

  http://thread.gmane.org/gmane.comp.bios.tianocore.devel/17470

I'll let others review your patches, especially concerning the concrete
SMBIOS contents.

Thanks!
Laszlo

> 
> Thanks,
> -Wei
> 
> Wei Huang (5):
>   smbios: extract x86 smbios building code into a function
>   smbios: remove dependency on x86 e820 tables
>   smbios: pass ram size as a parameter to build smbios tables
>   smbios: move smbios code into a common folder
>   smbios: implement smbios support for mach-virt
> 
>  arch_init.c                        |    2 +-
>  default-configs/arm-softmmu.mak    |    1 +
>  default-configs/i386-softmmu.mak   |    1 +
>  default-configs/x86_64-softmmu.mak |    1 +
>  hw/Makefile.objs                   |    1 +
>  hw/arm/virt.c                      |   24 +
>  hw/i386/Makefile.objs              |    2 +-
>  hw/i386/pc.c                       |   56 +-
>  hw/i386/pc_piix.c                  |    2 +-
>  hw/i386/pc_q35.c                   |    2 +-
>  hw/i386/smbios.c                   | 1102 
> ------------------------------------
>  hw/smbios/Makefile.objs            |    1 +
>  hw/smbios/smbios.c                 | 1102 
> ++++++++++++++++++++++++++++++++++++
>  include/hw/arm/virt-acpi-build.h   |    1 +
>  include/hw/i386/smbios.h           |  227 --------
>  include/hw/smbios/smbios.h         |  237 ++++++++
>  tests/bios-tables-test.c           |    2 +-
>  vl.c                               |    2 +-
>  18 files changed, 1414 insertions(+), 1352 deletions(-)
>  delete mode 100644 hw/i386/smbios.c
>  create mode 100644 hw/smbios/Makefile.objs
>  create mode 100644 hw/smbios/smbios.c
>  delete mode 100644 include/hw/i386/smbios.h
>  create mode 100644 include/hw/smbios/smbios.h
>