[Qemu-devel] memory hotplug fails with mem-merge option

[Bharata B Rao]

Hi,

When I use -machine pc,mem-merge=off|on -m 1G,slots=4,maxmem=2G, adding
memory-backend-ram object fails like below. Same failure is seen with
-machine pseries,mem-merge=on|off.

(qemu) object_add memory-backend-ram,id=ram0,size=1G

qemu-system-x86_64: util/qemu-option.c:388: qemu_opt_get_bool_helper: Assertion 
`opt->desc && opt->desc->type == QEMU_OPT_BOOL' failed.

Program received signal SIGABRT, Aborted.
0x00007ffff5b0b8d7 in raise () from /lib64/libc.so.6
(gdb) bt
#0  0x00007ffff5b0b8d7 in raise () from /lib64/libc.so.6
#1  0x00007ffff5b0d53a in abort () from /lib64/libc.so.6
#2  0x00007ffff5b0447d in __assert_fail_base () from /lib64/libc.so.6
#3  0x00007ffff5b04532 in __assert_fail () from /lib64/libc.so.6
#4  0x00005555559a65f5 in qemu_opt_get_bool_helper (opts=0x5555562f8cf0, 
    name=0x5555559dbb82 "mem-merge", defval=true, del=false) at 
util/qemu-option.c:388
#5  0x00005555559a6661 in qemu_opt_get_bool (opts=0x5555562f8cf0, 
    name=0x5555559dbb82 "mem-merge", defval=true) at util/qemu-option.c:398
#6  0x0000555555764878 in host_memory_backend_init (obj=0x555557101a90)
    at backends/hostmem.c:226
#7  0x00005555558b463c in object_init_with_type (obj=0x555557101a90, 
ti=0x5555562b8b20)
    at qom/object.c:314
#8  0x00005555558b461e in object_init_with_type (obj=0x555557101a90, 
ti=0x5555562b8d00)
    at qom/object.c:310
#9  0x00005555558b47e9 in object_initialize_with_type (data=0x555557101a90, 
size=344, 
    type=0x5555562b8d00) at qom/object.c:344
#10 0x00005555558b4b50 in object_new_with_type (type=0x5555562b8d00) at 
qom/object.c:430
#11 0x00005555558b4b8d in object_new (typename=0x5555570892c0 
"memory-backend-ram")
    at qom/object.c:440
#12 0x000055555574eea0 in object_add (type=0x5555570892c0 "memory-backend-ram", 
    id=0x5555577f7fc0 "ram0", qdict=0x555557884420, v=0x5555575b3d60, 
errp=0x7fffffffcab8)
    at qmp.c:629
#13 0x0000555555753ab8 in hmp_object_add (mon=0x55555633fec0, 
qdict=0x555557883400)
    at hmp.c:1638
#14 0x0000555555628223 in handle_hmp_command (mon=0x55555633fec0, 
    cmdline=0x55555637513b "memory-backend-ram,id=ram0,size=1G")
    at /home/bharata/work/powerkvm/frobisher/qemu-mainline/qemu/monitor.c:4058
#15 0x000055555562a992 in monitor_command_cb (opaque=0x55555633fec0, 
    cmdline=0x555556375130 "object_add memory-backend-ram,id=ram0,size=1G", 
    readline_opaque=0x0)
    at /home/bharata/work/powerkvm/frobisher/qemu-mainline/qemu/monitor.c:5081
#16 0x00005555559aa3ca in readline_handle_byte (rs=0x555556375130, ch=13)
    at util/readline.c:391
#17 0x000055555562a8ec in monitor_read (opaque=0x55555633fec0, 
    buf=0x7fffffffcc50 "\r\314\377\377\377\177", size=1)
    at /home/bharata/work/powerkvm/frobisher/qemu-mainline/qemu/monitor.c:5064
#18 0x00005555557295d0 in qemu_chr_be_write (s=0x55555630b690, 
    buf=0x7fffffffcc50 "\r\314\377\377\377\177", len=1) at qemu-char.c:306
#19 0x000055555572d9a9 in tcp_chr_read (chan=0x555557699f80, cond=G_IO_IN, 
    opaque=0x55555630b690) at qemu-char.c:2870
#20 0x00007ffff60e5aeb in g_main_context_dispatch () from 
/lib64/libglib-2.0.so.0
#21 0x00005555558fe14a in glib_pollfds_poll () at main-loop.c:199
#22 0x00005555558fe227 in os_host_main_loop_wait (timeout=1810450) at 
main-loop.c:244
#23 0x00005555558fe2e6 in main_loop_wait (nonblocking=0) at main-loop.c:493
#24 0x00005555557360d9 in main_loop () at vl.c:1902
#25 0x000055555573e0c6 in main (argc=20, argv=0x7fffffffe198, 
envp=0x7fffffffe240)
    at vl.c:4653