Re: [Qemu-devel] [PATCH] AioContext: fix broken ctx->dispatching optimization

[Paolo Bonzini]

On 16/07/2015 11:14, Kevin Wolf wrote:
>>> With this information, I understand that what has changed is that the
>>> > > return value of g_main_context_iteration() changes from true before this
>>> > > patch (had the aio_notify() from aio_set_fd_handler() pending) to false
>>> > > after the patch (aio_notify() doesn't inject an event any more).
>>> > > 
>>> > > This should mean that like above we can assert that the first iteration
>>> > > returns false, i.e. reverse the assertion (and indeed, with this
>>> > > change the test still passes for me).
>> > 
>> > I was a bit undecided about this.  In the end I decided that the calls
>> > to aio_poll/g_main_context_iteration were just to put the AioContext in
>> > a known state, and the assertions on the return value of g_assert were
>> > not really important.  For this reason, the while loop seemed to express
>> > the intentions best, and I made it consistent between the AioContext and
>> > GSource cases.
> You changed the AioContext case in this same patch, even if you didn't
> quote my comment on that hunk. :-)
> 
> Both cases were asserting the return value before.

I'll change the testcase (other than the aio_notify testcase) in a
separate patch.

Paolo