[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 0/3] AioContext: ctx->dispatching is dead, all ha
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH v2 0/3] AioContext: ctx->dispatching is dead, all hail ctx->notify_me |
Date: |
Thu, 16 Jul 2015 11:56:46 +0200 |
Apart from an additional assertion this is exactly the same code as v1,
but split across three patches so that the important one focuses on the
optimization.
Paolo
v1->v2
Split some changes to the tests to a separate patch
Fix commit message [Laszlo]
Clarify do...while loop in aio-win32.c [Kevin]
Paolo Bonzini (3):
tests: remove irrelevant assertions from test-aio
aio-win32: reorganize polling loop
AioContext: fix broken ctx->dispatching optimization
aio-posix.c | 19 ++++++------
aio-win32.c | 41 ++++++++++++++------------
async.c | 21 +++++---------
docs/aio_notify.promela | 77 +++++++++++++++++++++----------------------------
include/block/aio.h | 29 +++++++++++++++----
tests/test-aio.c | 26 +++--------------
6 files changed, 98 insertions(+), 115 deletions(-)
--
2.4.3
diff from v1:
diff --git a/aio-win32.c b/aio-win32.c
index ae7c6cf..9d6c12f 100644
--- a/aio-win32.c
+++ b/aio-win32.c
@@ -312,7 +312,13 @@ bool aio_poll(AioContext *ctx, bool blocking)
ctx->walking_handlers--;
first = true;
- /* wait until next event */
+ /* ctx->notifier is always registered. */
+ assert(count > 0);
+
+ /* Multiple iterations, all of them non-blocking except the first,
+ * may be necessary to process all pending events. After the first
+ * WaitForMultipleObjects call ctx->notify_me will be decremented.
+ */
do {
HANDLE event;
int ret;
- [Qemu-devel] [PATCH v2 0/3] AioContext: ctx->dispatching is dead, all hail ctx->notify_me,
Paolo Bonzini <=
- [Qemu-devel] [PATCH v2 2/3] aio-win32: reorganize polling loop, Paolo Bonzini, 2015/07/16
- [Qemu-devel] [PATCH v2 1/3] tests: remove irrelevant assertions from test-aio, Paolo Bonzini, 2015/07/16
- [Qemu-devel] [PATCH v2 3/3] AioContext: fix broken ctx->dispatching optimization, Paolo Bonzini, 2015/07/16
- Re: [Qemu-devel] [PATCH v2 0/3] AioContext: ctx->dispatching is dead, all hail ctx->notify_me, Kevin Wolf, 2015/07/16
- Re: [Qemu-devel] [PATCH v2 0/3] AioContext: ctx->dispatching is dead, all hail ctx->notify_me, Richard W.M. Jones, 2015/07/16
- Re: [Qemu-devel] [PATCH v2 0/3] AioContext: ctx->dispatching is dead, all hail ctx->notify_me, Richard W.M. Jones, 2015/07/16