Re: [Qemu-devel] [PATCH] crypto/cipher-nettle.c: Pass correct function type to cbc_encrypt and cbc_decrypt.

[Daniel P. Berrange]

On Thu, Jul 16, 2015 at 10:55:22AM +0100, Richard W.M. Jones wrote:
> The prototypes of the {nettle_}cbc_encrypt and cbc_decrypt functions
> are:
> 
> void
> cbc_encrypt(const void *ctx, nettle_cipher_func *f,
>             size_t block_size, uint8_t *iv,
>             size_t length, uint8_t *dst,
>             const uint8_t *src);
> 
> void
> cbc_decrypt(const void *ctx, nettle_cipher_func *f,
>             size_t block_size, uint8_t *iv,
>             size_t length, uint8_t *dst,
>             const uint8_t *src);
> 
> Since we passed nettle_crypt_func (instead of nettle_cipher_func) as
> the second argument, this gave the errors below.

Presumably you used Fedora rawhide which will have nettle 3.x
where as my code was written against FEdora 22 nettle 2.7.x
The function prototypes were changed in 3.x, so we need a
conditional fix - one was just sent in a pull request yesterday:

  https://lists.gnu.org/archive/html/qemu-devel/2015-07/msg03678.html

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|