[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.5 4/8] s390x: Dump storage keys qmp comman
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH for-2.5 4/8] s390x: Dump storage keys qmp command |
Date: |
Mon, 20 Jul 2015 08:32:50 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 07/20/2015 07:49 AM, Cornelia Huck wrote:
> From: "Jason J. Herne" <address@hidden>
>
> Provide a dump-skeys qmp command to allow the end user to dump storage
> keys. This is useful for debugging problems with guest storage key support
> within Qemu and for guest operating system developers.
>
> Reviewed-by: Thomas Huth <address@hidden>
> Reviewed-by: David Hildenbrand <address@hidden>
> Signed-off-by: Jason J. Herne <address@hidden>
> Signed-off-by: Cornelia Huck <address@hidden>
> ---
> +void qmp_dump_skeys(const char *filename, Error **errp)
> +{
> +
> + f = fopen(filename, "wb");
If you'll use qemu_fopen() here...
> +++ b/qapi-schema.json
> @@ -2058,6 +2058,19 @@
> 'returns': 'DumpGuestMemoryCapability' }
>
> ##
> +# @dump-skeys
> +#
> +# Dump guest's storage keys. @filename: the path to the file to dump to.
> +# This command is only supported on s390 architecture.
> +#
> +# Returns: nothing on success
> +#
> +# Since: 2.5
> +##
> +{ 'command': 'dump-skeys',
> + 'data': { 'filename': 'str' } }
then this command will automatically accept /dev/fdset/NNN notation for
allowing the user to pass in a file descriptor with add-fd then tying
that fd to this command (useful for when qemu is restricted from
directly calling open() for security reasons).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH for-2.5 3/8] s390x: Enable new s390-storage-keys device, (continued)
- [Qemu-devel] [PATCH for-2.5 3/8] s390x: Enable new s390-storage-keys device, Cornelia Huck, 2015/07/20
- [Qemu-devel] [PATCH for-2.5 1/8] s390x: add 2.5 compat s390-ccw-virtio machine, Cornelia Huck, 2015/07/20
- [Qemu-devel] [PATCH for-2.5 7/8] s390x: Migrate guest storage keys (initial memory only), Cornelia Huck, 2015/07/20
- [Qemu-devel] [PATCH for-2.5 6/8] s390x: Info skeys sub-command, Cornelia Huck, 2015/07/20
- [Qemu-devel] [PATCH for-2.5 8/8] s390x: Disable storage key migration on old machine type, Cornelia Huck, 2015/07/20
- [Qemu-devel] [PATCH for-2.5 2/8] s390x: Create QOM device for s390 storage keys, Cornelia Huck, 2015/07/20
- [Qemu-devel] [PATCH for-2.5 4/8] s390x: Dump storage keys qmp command, Cornelia Huck, 2015/07/20
- Re: [Qemu-devel] [PATCH for-2.5 4/8] s390x: Dump storage keys qmp command,
Eric Blake <=