qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RFC v2 04/47] qapi-event: Clean up how name of e


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH RFC v2 04/47] qapi-event: Clean up how name of enum QAPIEvent is made
Date: Mon, 20 Jul 2015 11:46:06 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0

On 07/01/2015 02:21 PM, Markus Armbruster wrote:
> Use c_name() instead of ad hoc code.  Doesn't upcase the -p prefix,
> which is an improvement in my book.  Unbreaks prefix containing '.',
> but other funny characters remain broken.  To be fixed next.
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  scripts/qapi-event.py  | 2 +-
>  tests/test-qmp-event.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

No change to the generated qapi-event.[ch], so it looks like only the
testsuite is affected.  [In fact, as far as I can tell, only
docs/qapi-code-gen.txt and tests/Makefile even take advantage of the '-p
prefix' argument.]  Fine by me.

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]