[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 04/38] block: Make bdrv_is_inserted() return a bo
From: |
Max Reitz |
Subject: |
[Qemu-devel] [PATCH v4 04/38] block: Make bdrv_is_inserted() return a bool |
Date: |
Mon, 20 Jul 2015 19:45:31 +0200 |
Make bdrv_is_inserted(), blk_is_inserted(), and the callback
BlockDriver.bdrv_is_inserted() return a bool.
Suggested-by: Eric Blake <address@hidden>
Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
---
block.c | 12 +++++++-----
block/block-backend.c | 2 +-
block/raw-posix.c | 8 +++-----
block/raw_bsd.c | 2 +-
include/block/block.h | 2 +-
include/block/block_int.h | 2 +-
include/sysemu/block-backend.h | 2 +-
7 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/block.c b/block.c
index d088ee0..494e08e 100644
--- a/block.c
+++ b/block.c
@@ -3228,14 +3228,16 @@ void bdrv_invalidate_cache_all(Error **errp)
/**
* Return TRUE if the media is present
*/
-int bdrv_is_inserted(BlockDriverState *bs)
+bool bdrv_is_inserted(BlockDriverState *bs)
{
BlockDriver *drv = bs->drv;
- if (!drv)
- return 0;
- if (!drv->bdrv_is_inserted)
- return 1;
+ if (!drv) {
+ return false;
+ }
+ if (!drv->bdrv_is_inserted) {
+ return true;
+ }
return drv->bdrv_is_inserted(bs);
}
diff --git a/block/block-backend.c b/block/block-backend.c
index aee8a12..7afd5c0 100644
--- a/block/block-backend.c
+++ b/block/block-backend.c
@@ -752,7 +752,7 @@ void blk_invalidate_cache(BlockBackend *blk, Error **errp)
bdrv_invalidate_cache(blk->bs, errp);
}
-int blk_is_inserted(BlockBackend *blk)
+bool blk_is_inserted(BlockBackend *blk)
{
return bdrv_is_inserted(blk->bs);
}
diff --git a/block/raw-posix.c b/block/raw-posix.c
index 83d7054..bf5d780 100644
--- a/block/raw-posix.c
+++ b/block/raw-posix.c
@@ -2386,15 +2386,13 @@ out:
return prio;
}
-static int cdrom_is_inserted(BlockDriverState *bs)
+static bool cdrom_is_inserted(BlockDriverState *bs)
{
BDRVRawState *s = bs->opaque;
int ret;
ret = ioctl(s->fd, CDROM_DRIVE_STATUS, CDSL_CURRENT);
- if (ret == CDS_DISC_OK)
- return 1;
- return 0;
+ return ret == CDS_DISC_OK;
}
static void cdrom_eject(BlockDriverState *bs, bool eject_flag)
@@ -2520,7 +2518,7 @@ static int cdrom_reopen(BlockDriverState *bs)
return 0;
}
-static int cdrom_is_inserted(BlockDriverState *bs)
+static bool cdrom_is_inserted(BlockDriverState *bs)
{
return raw_getlength(bs) > 0;
}
diff --git a/block/raw_bsd.c b/block/raw_bsd.c
index e3d2d04..d718583 100644
--- a/block/raw_bsd.c
+++ b/block/raw_bsd.c
@@ -154,7 +154,7 @@ static int raw_truncate(BlockDriverState *bs, int64_t
offset)
return bdrv_truncate(bs->file, offset);
}
-static int raw_is_inserted(BlockDriverState *bs)
+static bool raw_is_inserted(BlockDriverState *bs)
{
return bdrv_is_inserted(bs->file);
}
diff --git a/include/block/block.h b/include/block/block.h
index 37916f7..2eee6c5 100644
--- a/include/block/block.h
+++ b/include/block/block.h
@@ -397,7 +397,7 @@ int bdrv_is_read_only(BlockDriverState *bs);
int bdrv_is_sg(BlockDriverState *bs);
int bdrv_enable_write_cache(BlockDriverState *bs);
void bdrv_set_enable_write_cache(BlockDriverState *bs, bool wce);
-int bdrv_is_inserted(BlockDriverState *bs);
+bool bdrv_is_inserted(BlockDriverState *bs);
int bdrv_media_changed(BlockDriverState *bs);
void bdrv_lock_medium(BlockDriverState *bs, bool locked);
void bdrv_eject(BlockDriverState *bs, bool eject_flag);
diff --git a/include/block/block_int.h b/include/block/block_int.h
index 14ad4c3..f3b3354 100644
--- a/include/block/block_int.h
+++ b/include/block/block_int.h
@@ -213,7 +213,7 @@ struct BlockDriver {
const char *backing_file, const char *backing_fmt);
/* removable device specific */
- int (*bdrv_is_inserted)(BlockDriverState *bs);
+ bool (*bdrv_is_inserted)(BlockDriverState *bs);
int (*bdrv_media_changed)(BlockDriverState *bs);
void (*bdrv_eject)(BlockDriverState *bs, bool eject_flag);
void (*bdrv_lock_medium)(BlockDriverState *bs, bool locked);
diff --git a/include/sysemu/block-backend.h b/include/sysemu/block-backend.h
index 8fc960f..8f2bf10 100644
--- a/include/sysemu/block-backend.h
+++ b/include/sysemu/block-backend.h
@@ -130,7 +130,7 @@ int blk_is_sg(BlockBackend *blk);
int blk_enable_write_cache(BlockBackend *blk);
void blk_set_enable_write_cache(BlockBackend *blk, bool wce);
void blk_invalidate_cache(BlockBackend *blk, Error **errp);
-int blk_is_inserted(BlockBackend *blk);
+bool blk_is_inserted(BlockBackend *blk);
void blk_lock_medium(BlockBackend *blk, bool locked);
void blk_eject(BlockBackend *blk, bool eject_flag);
int blk_get_flags(BlockBackend *blk);
--
2.4.6
- [Qemu-devel] [PATCH v4 00/38] blockdev: BlockBackend and media, Max Reitz, 2015/07/20
- [Qemu-devel] [PATCH v4 01/38] block: Remove host floppy support, Max Reitz, 2015/07/20
- [Qemu-devel] [PATCH v4 02/38] blockdev: Allow creation of BDS trees without BB, Max Reitz, 2015/07/20
- [Qemu-devel] [PATCH v4 03/38] iotests: Only create BB if necessary, Max Reitz, 2015/07/20
- [Qemu-devel] [PATCH v4 05/38] block: Add blk_is_available(), Max Reitz, 2015/07/20
- [Qemu-devel] [PATCH v4 06/38] block: Make bdrv_is_inserted() recursive, Max Reitz, 2015/07/20
- [Qemu-devel] [PATCH v4 04/38] block: Make bdrv_is_inserted() return a bool,
Max Reitz <=
- [Qemu-devel] [PATCH v4 07/38] block/quorum: Implement bdrv_is_inserted(), Max Reitz, 2015/07/20
- [Qemu-devel] [PATCH v4 08/38] block: Invoke change media CB before NULLing drv, Max Reitz, 2015/07/20
- [Qemu-devel] [PATCH v4 10/38] hw/usb-storage: Check whether BB is inserted, Max Reitz, 2015/07/20
- [Qemu-devel] [PATCH v4 09/38] hw/block/fdc: Implement tray status, Max Reitz, 2015/07/20
- [Qemu-devel] [PATCH v4 11/38] block: Fix BB AIOCB AioContext without BDS, Max Reitz, 2015/07/20
- [Qemu-devel] [PATCH v4 12/38] block: Move guest_block_size into BlockBackend, Max Reitz, 2015/07/20
- [Qemu-devel] [PATCH v4 13/38] block: Remove wr_highest_sector from BlockAcctStats, Max Reitz, 2015/07/20
- [Qemu-devel] [PATCH v4 14/38] block: Move BlockAcctStats into BlockBackend, Max Reitz, 2015/07/20
- [Qemu-devel] [PATCH v4 16/38] block: Add BlockBackendRootState, Max Reitz, 2015/07/20
- [Qemu-devel] [PATCH v4 15/38] block: Move I/O status and error actions into BB, Max Reitz, 2015/07/20