[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] crypto: extend unit tests to cover decryption t
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH] crypto: extend unit tests to cover decryption too |
|
Date: |
Mon, 20 Jul 2015 22:37:15 +0100 |
On 20 July 2015 at 21:57, Eric Blake <address@hidden> wrote:
> On 07/20/2015 11:28 AM, Daniel P. Berrange wrote:
>> The current unit test only verify the encryption API, which
>
> grammatical mismatch; you want either:
> tests only verify
> test only verifies
>
>> resulted in us missing a recently introduced bug in the
>> decryption API from commit d3462e3. It was fortunately
>> later discovered & fixed by commit bd0959 thanks to the
>
> Is a 6-byte SHA going to stay unambiguous long enough? git defaults to
> 7-byte to reduce chances of collisions by 16.
Fortunately causality allows us to disambiguate by knowing
that Daniel can only be referring to a commit that's
already happened rather than one in the future :-)
-- PMM