[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] crypto: extend unit tests to cover decryptio
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] crypto: extend unit tests to cover decryption too |
|
Date: |
Tue, 21 Jul 2015 06:51:04 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 07/21/2015 02:55 AM, Daniel P. Berrange wrote:
> The current unit test only verifies the encryption API,
> resulting in us missing a recently introduced bug in the
> decryption API from commit d3462e3. It was fortunately
> later discovered & fixed by commit bd09594, thanks to the
> QEMU I/O tests for qcow2 encryption, but we should really
> detect this directly in the crypto unit tests. Also remove
> an accidental debug message and simplify some asserts.
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> tests/test-crypto-cipher.c | 28 ++++++++++++++++++++--------
> 1 file changed, 20 insertions(+), 8 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature