[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.4 1/1] qga: fixed versions for guest bus t
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH for-2.4 1/1] qga: fixed versions for guest bus types in qapi-schema |
|
Date: |
Tue, 21 Jul 2015 08:19:49 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 07/21/2015 06:25 AM, Denis V. Lunev wrote:
> From: Olga Krishtal <address@hidden>
>
> Signed-off-by: Olga Krishtal <address@hidden>
> Signed-off-by: Denis V. Lunev <address@hidden>
> CC: Eric Blake <address@hidden>
> CC: Michael Roth <address@hidden>
doc-only, so I've added 2.4 to the subject line.
> ---
> qga/qapi-schema.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
> index 8a9b818..b81b212 100644
> --- a/qga/qapi-schema.json
> +++ b/qga/qapi-schema.json
> @@ -714,7 +714,7 @@
> # @virtual: Win virtual bus type
> # @file-backed virtual: Win file-backed bus type
> #
> -# Since: 2.2
> +# Since: 2.2 'Unknown' and all entries below since 2.4
I would have put a comma or semicolon there for legibility:
Since: 2.2; 'Unknown' and ...
but it's minor enough that a maintainer could touch it up, or even live
with it as is, without needing a v2.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature