Re: [Qemu-devel] [PATCH RFC v2 18/47] qapi-commands: Don't feed output of mcgen() to mcgen() again

[Eric Blake]

On 07/01/2015 02:22 PM, Markus Armbruster wrote:
> Multiple passes through mcgen() is prone to produce unwanted blank
> lines, which we then combat by sprinkling .rstrip() on top.  Just
> don't do it.
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  scripts/qapi-commands.py | 52 
> +++++++++++++++++++-----------------------------
>  1 file changed, 21 insertions(+), 31 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

Causes the generated files to be slightly shorter (good), with diffs
like the following:

--- qga/qapi-generated/qga-qmp-marshal.c.old    2015-07-20
17:13:06.056297347 -0600
+++ qga/qapi-generated/qga-qmp-marshal.c        2015-07-21
11:16:09.887228043 -0600
@@ -140,7 +140,6 @@
     (void)args;
     qmp_guest_ping(&local_err);
     error_propagate(errp, local_err);
-
 }

 static void qmp_marshal_output_guest_get_time(int64_t ret_in, QObject
**ret_out, Error **errp)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature