[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 5/7] fw_cfg file sort
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [RFC 5/7] fw_cfg file sort |
Date: |
Tue, 21 Jul 2015 21:53:06 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 07/21/15 18:18, Stefan Hajnoczi wrote:
> On Tue, Jul 21, 2015 at 5:03 PM, Marc Marí <address@hidden> wrote:
>> From: Gerd Hoffmann <address@hidden>
>>
>> This is what it takes to have a sorted fw_cfg file directory.
>> Entries are inserted at the correct place instead of being
>> appended to the end in case sorting is enabled.
>>
>> Compatibility fluff (enable sorting for new machine types only)
>> isn't there yet.
>>
>> Signed-off-by: Gerd Hoffmann <address@hidden>
>> ---
>> hw/nvram/fw_cfg.c | 30 ++++++++++++++++++++++++------
>> 1 file changed, 24 insertions(+), 6 deletions(-)
>
> Probably best to drop this patch from this series, unless it's needed.
>
> I guess sorting files allows for binary search but it's unrelated to
> DMA and needs to be accompanied with guest code (e.g. SeaBIOS) that
> actually uses the feature.
I recall another discussion where the sorting was considered under a
migration aspect (not for the sake of binary search on the guest side).
.... Yes, here it is:
http://thread.gmane.org/gmane.comp.emulators.qemu/340424/focus=342398
The commit message should give a full rationale, preferably.
Thanks!
Laszlo
- Re: [Qemu-devel] [RFC 4/7] enable fw_cfg dma for arm virt, (continued)
- [Qemu-devel] [RFC 6/7] Add offset register to fw_cfg DMA interface, Marc Marí, 2015/07/21
- Re: [Qemu-devel] [RFC 6/7] Add offset register to fw_cfg DMA interface, Stefan Hajnoczi, 2015/07/21
- Re: [Qemu-devel] [RFC 6/7] Add offset register to fw_cfg DMA interface, Laszlo Ersek, 2015/07/21
- Re: [Qemu-devel] [RFC 6/7] Add offset register to fw_cfg DMA interface, Kevin O'Connor, 2015/07/21
- Re: [Qemu-devel] [RFC 6/7] Add offset register to fw_cfg DMA interface, Laszlo Ersek, 2015/07/21
- Re: [Qemu-devel] [RFC 6/7] Add offset register to fw_cfg DMA interface, Kevin O'Connor, 2015/07/22
- Re: [Qemu-devel] [RFC 6/7] Add offset register to fw_cfg DMA interface, Marc Marí, 2015/07/22
Re: [Qemu-devel] [RFC 6/7] Add offset register to fw_cfg DMA interface, Stefan Hajnoczi, 2015/07/21