[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] block/ssh: Avoid segfault if inet_connect do
|
From: |
Richard W.M. Jones |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] block/ssh: Avoid segfault if inet_connect doesn't set errno. |
|
Date: |
Wed, 22 Jul 2015 14:22:18 +0100 |
|
User-agent: |
Mutt/1.5.20 (2009-12-10) |
On Wed, Jul 22, 2015 at 09:17:49AM -0400, Jeff Cody wrote:
> Both nbd and sheepdog handle it in a similar fashion (i.e. not relying
> on errno being set on inet_connect failure). However, both nbd and
> sheepdog use -EIO as the error return, and I think that makes more
> sense. What do you think?
If you prefer -- I don't mind as long as it doesn't segfault :-)
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages. http://libguestfs.org