[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/2] block: warn about aio=native if libaio i
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 0/2] block: warn about aio=native if libaio is unavailable |
|
Date: |
Thu, 23 Jul 2015 10:08:31 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 |
On 23/07/2015 10:03, Markus Armbruster wrote:
>
>> > v2:
>> > * Banish CONFIG_LINUX_AIO from blockdev.c, that is raw-posix.c's business
>> > [Kevin]
>> > * Print the warning in the same way as the aio=native,cache.direct=off
>> > deprecation warning [Kevin]
>> >
>> > Open question: what about the Windows case? We now pass the
>> > FILE_FLAG_OVERLAPPED flag which we didn't do before for -drive aio=native.
> Odd. Commit a273652 takes the trouble to implement native asynchronous
> I/O there, but unless CONFIG_LINUX_AIO somehow gets defined, it's
> unreachable, isn't it? Paolo?
I don't remember how I tested that code, but it's probably been dead
code since it was committed. If it's bitrot and thus these patches
break it, I will fix it.
Paolo
> I think PATCH 2's commit message needs to be updated to discuss the
> impact.