[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/5] replace qemu_fls() with pow2ceil()/pow2floo
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 0/5] replace qemu_fls() with pow2ceil()/pow2floor() |
|
Date: |
Fri, 24 Jul 2015 07:10:23 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 |
On 23/07/2015 22:10, Peter Maydell wrote:
>> > The series looks good, but I'd prefer (especially for patch 4 which is
>> > in a fast path) if pow2ceil and pow2floor were made inline.
> Yeah, I was wondering if I was going to be asked to do that.
> Note that qemu_fls() is/was *not* inline, though, so you're
> taking an out-of-line function call on these code paths
> already.
But in patch 4 the call is only in the rare case where "l & (l - 1)" is
not zero.
Paolo
- [Qemu-devel] [PATCH 0/5] replace qemu_fls() with pow2ceil()/pow2floor(), Peter Maydell, 2015/07/23
- [Qemu-devel] [PATCH 3/5] hw/block/nvme.c: Use pow2ceil() rather than hand-calculation, Peter Maydell, 2015/07/23
- Re: [Qemu-devel] [PATCH 0/5] replace qemu_fls() with pow2ceil()/pow2floor(), Paolo Bonzini, 2015/07/23
- [Qemu-devel] [PATCH 5/5] Remove unused qemu_fls function, Peter Maydell, 2015/07/23
- [Qemu-devel] [PATCH 4/5] exec.c: Use pow2floor() rather than hand-calculation, Peter Maydell, 2015/07/23
- [Qemu-devel] [PATCH 2/5] hw/virtio/virtio-pci: Use pow2ceil() rather than hand-calculation, Peter Maydell, 2015/07/23
- [Qemu-devel] [PATCH 1/5] hw/pci: Use pow2ceil() rather than hand-calculation, Peter Maydell, 2015/07/23
- Re: [Qemu-devel] [PATCH 0/5] replace qemu_fls() with pow2ceil()/pow2floor(), Paolo Bonzini, 2015/07/23