Re: [Qemu-devel] [PULL v3 00/12] Final changes for 2.4-rc0

[Daniel P. Berrange]

On Fri, Jul 24, 2015 at 03:55:56PM +0200, Paolo Bonzini wrote:
> 
> 
> On 24/07/2015 15:31, Peter Maydell wrote:
> > Yes, but the set of required static libs for linux-user is pretty
> > tiny, and it doesn't generally change. In particular since we
> > don't want to link gnutls into linux-user we shouldn't be requiring
> > the user to scrape up a static lib of it to keep things working.
> > Requiring gnutls at all for these configure options is just a bug
> > (in configure or the makefile).
> 
> Can you check if this works?
> 
> diff --git a/Makefile.objs b/Makefile.objs
> index f094eff..9d988d9 100644
> --- a/Makefile.objs
> +++ b/Makefile.objs
> @@ -2,7 +2,9 @@
>  # Common libraries for tools and emulators
>  stub-obj-y = stubs/
>  util-obj-y = util/ qobject/ qapi/ qapi-types.o qapi-visit.o qapi-event.o
> -util-obj-y += crypto/
> +
> +util-obj-$(call notempty,$(TOOLS)) += crypto/
> +util-obj-$(CONFIG_SOFTMMU) += crypto/

I have a feeling that'd cause the test suite to fail to link,
because it expects it to be unconditionally present in the
libqemuutil.a lib.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|