Re: [Qemu-devel] [PATCH v7 2/6] Implement GIC-500 base class

[Peter Maydell]

On 26 July 2015 at 14:52, Pavel Fedin <address@hidden> wrote:

>> This whole struct reads like "we just took the GICv2 state
>> and changed it as little as possible beyond bumping the
>> NCPU define a bit". That doesn't make me very confident
>> that it's actually correct for GICv3...
>
>  At least, with complete Shlomo's SW emulation code, it works.
>  And could you be not so strict on this file? It's actually Shlomo's
> work, not my one, i include it only because i need to base on
> something. He will fix up the rest of SW emulation stuff.

Data structures are important -- they're the foundation on
which everything else rests (and at some point they get
baked into VM migration formats, though we aren't at that
point yet). It's worth getting them right from the start.

thanks
-- PMM