[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V4 2/3] virtio-blk: fail get_features when both
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH V4 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set |
|
Date: |
Mon, 27 Jul 2015 13:30:30 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 |
On 27/07/2015 13:26, Michael S. Tsirkin wrote:
>>> > > + if (s->conf.scsi) {
>>> > > + error_setg(errp, "Virtio 1.0 does not support scsi
>>> > > passthrough!");
>> >
>> > Unclear error message, as one would expect SCSI passthrough not to work
>> > anyway for e.g. a disk backed by a file.
> Right - so I suggested:
> Virtio modern does not support scsi passthrough - please set
> disable-modern=on or switch to virtio-scsi.
> With that change - ACK?
scsi=on by default, so everyone is getting the message until they
disable virtio 1.0. Suggesting a switch to virtio-scsi doesn't make sense.
Your proposal makes sense once scsi=off by default. Until then, what
about "please set scsi=off for virtio-blk devices in order to use virtio
1.0"?
Paolo
[Qemu-devel] [PATCH V4 3/3] virtio-blk: only clear VIRTIO_F_ANY_LAYOUT for legacy device, Jason Wang, 2015/07/27
Re: [Qemu-devel] [PATCH V4 0/3] Set correct blk feature for virtio 1.0, Paolo Bonzini, 2015/07/27