Re: [Qemu-devel] [PATCH v2 for-2.5 05/12] tcg/optimize: track const/copy status separately

[Paolo Bonzini]

On 27/07/2015 15:40, Aurelien Jarno wrote:
> >          temps[dst].next_copy = temps[src].next_copy;
> >          temps[dst].prev_copy = src;
> >          temps[temps[dst].next_copy].prev_copy = dst;
> >          temps[src].next_copy = dst;
>
> Note that the patch doesn't change this part, it's already there in the
> original code.

Understood.

> > This is:
> > 
> >     dst->next = src->next;
> >     dst->prev = src;
> >     dst->next->prev = dst;
> >     src->next = dst;
> 
> Here we just want to insert one element, and thus before
> the insertion we have dst->next = dst->prev = dst.

Ah, you're right.

Paolo