qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 2/2] QOM: object_property_add() performance i


From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH v4 2/2] QOM: object_property_add() performance improvement
Date: Mon, 27 Jul 2015 16:57:17 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0

Hi,

Am 27.07.2015 um 16:36 schrieb Pavel Fedin:
>> Do we really want '#' in property names?  Elsewhere, we require names to
>> be id_wellformed().
> 
>  I already asked this question to Andreas but got no single reply from him. 
> My initial idea was to leave '[*]' as a suffix for this magic property. He 
> only told that he doesn't like it.

And I was waiting for replies on your suggestion, as I had concerns
about that '#'.

>  I am absolutely fine with absolutely anything. Suggest what you like and 
> i'll change it.

Paolo suggested ...-count on #qemu, but I would prefer ...-max or so, as
the number could differ when some property gets deleted.

On the other hand, since this is not a user-added property, using a
reserved character such as '#' would avoid clashes with user-added
properties, as long as tools handle accessing that property okay.

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB
21284 (AG Nürnberg)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]