[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC 2/6] posix: add linux-only memfd fallback
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH RFC 2/6] posix: add linux-only memfd fallback |
|
Date: |
Tue, 28 Jul 2015 13:50:50 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 |
On 28/07/2015 12:58, Marc-André Lureau wrote:
> Hi
>
> On Tue, Jul 28, 2015 at 10:11 AM, Paolo Bonzini <address@hidden> wrote:
>>>
>>> What's defining all these macros?
>>
>> They're in asm/unistd.h.
>>
>> I think that, instead of making qemu/osdep.h the new qemu-common.h, the
>> wrappers added by patch 3 should be declared in a new header
>> qemu/memfd.h. The implementation in util/memfd.c can include both
>> linux/fcntl.h and asm/unistd.h.
>>
>
> Ok, shouldn't it keep the inline function? this avoids future clash
> when upgrading glibc.
Can the inline function stay in util/memfd.c?
Paolo
[Qemu-devel] [PATCH RFC 3/6] osdep: add memfd helpers, Marc-André Lureau, 2015/07/22
[Qemu-devel] [PATCH RFC 4/6] vhost: alloc shareable log, Marc-André Lureau, 2015/07/22
[Qemu-devel] [PATCH RFC 5/6] vhost-user: send log shm fd along with log_base, Marc-André Lureau, 2015/07/22
[Qemu-devel] [PATCH RFC 6/6] vhost-user: document migration log, Marc-André Lureau, 2015/07/22