Re: [Qemu-devel] [PATCH v2 02/45] msix: add VMSTATE_MSIX_TEST

[Paolo Bonzini]

On 28/07/2015 02:32, Marc-André Lureau wrote:
> From: Marc-André Lureau <address@hidden>
> 
> ivshmem is going to use MSIX state conditionally.
> 
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>  include/hw/pci/msix.h | 16 ++++++++++------
>  1 file changed, 10 insertions(+), 6 deletions(-)
> 
> diff --git a/include/hw/pci/msix.h b/include/hw/pci/msix.h
> index 954d82b..72e5f93 100644
> --- a/include/hw/pci/msix.h
> +++ b/include/hw/pci/msix.h
> @@ -46,12 +46,16 @@ void msix_unset_vector_notifiers(PCIDevice *dev);
>  
>  extern const VMStateDescription vmstate_msix;
>  
> -#define VMSTATE_MSIX(_field, _state) {                               \
> -    .name       = (stringify(_field)),                               \
> -    .size       = sizeof(PCIDevice),                                 \
> -    .vmsd       = &vmstate_msix,                                     \
> -    .flags      = VMS_STRUCT,                                        \
> -    .offset     = vmstate_offset_value(_state, _field, PCIDevice),   \
> +#define VMSTATE_MSIX_TEST(_field, _state, _test) {                   \
> +    .name         = (stringify(_field)),                             \
> +    .size         = sizeof(PCIDevice),                               \
> +    .vmsd         = &vmstate_msix,                                   \
> +    .flags        = VMS_STRUCT,                                      \
> +    .offset       = vmstate_offset_value(_state, _field, PCIDevice), \
> +    .field_exists = (_test)                                          \
>  }
>  
> +#define VMSTATE_MSIX(_f, _s)                                         \
> +    VMSTATE_MSIX_TEST(_f, _s, NULL)
> +
>  #endif
> 

Why can't it be saved unconditionally?

Paolo