qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH] ioapic: coalesce level interrupts


From: Paolo Bonzini
Subject: [Qemu-devel] [PATCH] ioapic: coalesce level interrupts
Date: Thu, 30 Jul 2015 10:20:08 +0200

If a level-triggered interrupt goes down and back up before the
corresponding EOI, it should be coalesced.  This fixes one testcase
in kvm-unit-tests' ioapic.flat.

Signed-off-by: Paolo Bonzini <address@hidden>
---
 hw/intc/ioapic.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/hw/intc/ioapic.c b/hw/intc/ioapic.c
index b527932..6ad3c66 100644
--- a/hw/intc/ioapic.c
+++ b/hw/intc/ioapic.c
@@ -98,7 +98,9 @@ static void ioapic_set_irq(void *opaque, int vector, int 
level)
             /* level triggered */
             if (level) {
                 s->irr |= mask;
-                ioapic_service(s);
+                if (!(entry & IOAPIC_LVT_REMOTE_IRR)) {
+                    ioapic_service(s);
+                }
             } else {
                 s->irr &= ~mask;
             }
-- 
2.4.3




reply via email to

[Prev in Thread] Current Thread [Next in Thread]