qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 01/12] qapi/qmp-event.c: Don't manually include


From: Daniel P. Berrange
Subject: Re: [Qemu-devel] [PATCH 01/12] qapi/qmp-event.c: Don't manually include os-win32.h/os-posix.h
Date: Fri, 31 Jul 2015 13:46:10 +0100
User-agent: Mutt/1.5.23 (2014-03-12)

On Wed, Jul 22, 2015 at 05:44:00PM +0100, Peter Maydell wrote:
> qmp-event.c already includes qemu-common.h, so manually including
> os-win32.h/os-posix.h is unnecessary (and potentially fragile,
> since it's duplicating the #ifdef logic that chooses which of the
> two we need). Remove the unnecessary include logic.
> 
> Signed-off-by: Peter Maydell <address@hidden>
> ---
>  qapi/qmp-event.c | 8 --------
>  1 file changed, 8 deletions(-)

Reviewed-by: Daniel P. Berrange <address@hidden>

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|



reply via email to

[Prev in Thread] Current Thread [Next in Thread]