Re: [Qemu-devel] [PATCH for-2.4] oslib-win32: only provide localtime_r/gmtime_r if missing

[Stefan Weil]

Am 31.07.2015 um 14:49 schrieb Paolo Bonzini:
> On 31/07/2015 12:17, Daniel P. Berrange wrote:
> >    CC    util/osdep.o
> > In file included from include/qemu-common.h:48:0,
> >                   from util/osdep.c:48:
> > include/sysemu/os-win32.h:77:12: error: redundant redeclaration of 'gmtime_r' 
> > [-Werror=redundant-decls]
> >   struct tm *gmtime_r(const time_t *timep, struct tm *result);
> >              ^
> > In file included from include/qemu-common.h:35:0,
> >                   from util/osdep.c:48:
> > /usr/i686-w64-mingw32/sys-root/mingw/include/time.h:272:107: note: previous 
> > definition of 'gmtime_r' was here
> > In file included from include/qemu-common.h:48:0,
> >                   from util/osdep.c:48:
> > include/sysemu/os-win32.h:79:12: error: redundant redeclaration of 
> > 'localtime_r' [-Werror=redundant-decls]
> >   struct tm *localtime_r(const time_t *timep, struct tm *result);
> >              ^
> > In file included from include/qemu-common.h:35:0,
> >                   from util/osdep.c:48:
> > /usr/i686-w64-mingw32/sys-root/mingw/include/time.h:269:107: note: previous 
> > definition of 'localtime_r' was here
> >
> > This change adds a configure test to see if localtime_r
> > exits, and only enables the QEMU impl if missing. We also
> > re-arrange qemu-common.h try attempt to guarantee that all
> > source files get unistd.h before time.h and thus see the
> > localtime_r/gmtime_r defs.
> These are only with --enable-werror, right?  The patch shouldn't be
> necessary for 2.4.
>
> Paolo

It isn't necessary for 2.4. There are more severe problems which also
seem to be triggered by recent changes in the MinGW-w64 toolchain:

64 bit executables crash at longjmp from generated code,
and networking fails because of asynchronous connect calls
which were never implemented correctly in the slirp code.
I'll try to summarize all that I know in a separate mail later.

I only recently got reports about these problems and think
that it is too late to fix them in 2.4.0.

Stefan