qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [kvm-unit-tests PATCH v5 05/11] lib/printf: support the


From: Andrew Jones
Subject: Re: [Qemu-devel] [kvm-unit-tests PATCH v5 05/11] lib/printf: support the %u unsigned fmt field
Date: Fri, 31 Jul 2015 20:25:40 +0200
User-agent: Mutt/1.5.23.1 (2014-03-12)

On Fri, Jul 31, 2015 at 04:53:55PM +0100, Alex Bennée wrote:
> ---
>  lib/printf.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)

missing sign-off

> 
> diff --git a/lib/printf.c b/lib/printf.c
> index 89308fb..5d83605 100644
> --- a/lib/printf.c
> +++ b/lib/printf.c
> @@ -180,6 +180,19 @@ int vsnprintf(char *buf, int size, const char *fmt, 
> va_list va)
>               break;
>           }
>           break;
> +     case 'u':
> +         switch (nlong) {
> +         case 0:
> +             print_unsigned(&s, va_arg(va, unsigned), 10, props);
> +             break;
> +         case 1:
> +             print_unsigned(&s, va_arg(va, unsigned long), 10, props);
> +             break;
> +         default:
> +             print_unsigned(&s, va_arg(va, unsigned long long), 10, props);
> +             break;
> +         }
> +         break;
>       case 'x':
>           switch (nlong) {
>           case 0:
> -- 
> 2.5.0

Otherwise
Reviewed-by: Andrew Jones <address@hidden>
> 
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]