[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 6/6] Add gicversion option to virt machine
From: |
Pavel Fedin |
Subject: |
Re: [Qemu-devel] [PATCH v7 6/6] Add gicversion option to virt machine |
Date: |
Mon, 03 Aug 2015 10:19:09 +0300 |
Hello!
> > gicdev = qdev_create(NULL, gictype);
> > - qdev_prop_set_uint32(gicdev, "revision", 2);
> > +
> > + for (i = 0; i < vbi->smp_cpus; i++) {
> > + CPUState *cpu = qemu_get_cpu(i);
> > + CPUARMState *env = cpu->env_ptr;
> > + env->nvic = gicdev;
> > + }
>
> We definitely need to come up with a something cleaner
> than this (which is ugly for two reasons
This could be done:
a) as property
b) as global variable because 'gicdev' is a single of its kind.
But, actually, this is currently only for TCG, which needs it in order to
forward system register accesses to GICv3 code. Would it be OK if i just omit
this assignment ?
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
- Re: [Qemu-devel] [PATCH v7 6/6] Add gicversion option to virt machine,
Pavel Fedin <=