Re: [Qemu-devel] [PATCH v2] qemu-ga: Prevent QEMU-GA VSS provider from being unregistered on reinstall

[Marc-André Lureau]

Hi

On Mon, Aug 3, 2015 at 3:00 PM, Leonid Bloch <address@hidden> wrote:
>>
>> yes, but if you remove that RemoveExistingProducts too, then what fails?
> Only the manual call for RemoveExistingProducts is removed.
> MajorUpgrade places it automatically in the InstallExecuteSequence
> table.


I think the root of the problem is that the wxs doesn't follow the
"component rules": "qemu_ga" shouldn't contain various libs and
executable. Instead, each file should have its own component. Then I
think RemoveExistingProducts would actually remove only the components
that are to be upgraded. And that REINSTALLMODE trick wouldn't be
necessary. I would fix to follow the principles recommended here:
https://msdn.microsoft.com/en-us/library/aa368269%28VS.85%29.aspx.


-- 
Marc-André Lureau