[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] i6300esb: correctly convert watchdog clock tick
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH] i6300esb: correctly convert watchdog clock ticks into nanoseconds |
|
Date: |
Mon, 3 Aug 2015 17:18:34 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 03/08/2015 17:13, Laurent Vivier wrote:
>>> >> it says "33 MHz clock (30 ns clock ticks)" which is contradictory.
>> >
>> > I found that the spec allows for any speed up to 33333333 Hz (30 ns
>> > cycle), so both are okay. However, at least hw/net/rtl8139.c assumes
>> > it's 33000000 Hz, so it's nice to be consistent.
> So, do you want I resend a patch with "1000 / 33" instead ?
>
> We can also update hw/net/rtl8139.c to replace "muldiv64(X,
> get_ticks_per_sec(), 33000000)" by "X * 30" ?
Either would do. If you modify hw/net/rtl8139.c you have to modify CLK
in tests/test-rtl8139.c as well.
Paolo
[Qemu-devel] [PATCH][TRIVIAL] i6300esb: fix timer overflow, Laurent Vivier, 2015/08/04
Re: [Qemu-devel] [PATCH] i6300esb: correctly convert watchdog clock ticks into nanoseconds, Richard W.M. Jones, 2015/08/04