Re: [Qemu-devel] [PATCH 2/3] target-mips: Stop translation after unconditional exceptions

[Richard Henderson]

On 08/03/2015 02:31 PM, Aurelien Jarno wrote:
> On 2015-08-03 11:49, Richard Henderson wrote:
> > Since there are many more unconditional exceptions than conditional,
> > introduce a new generate_exception_cond to mark conditionals.  Also
> > delete those few cases where we did attempt to stop translation after
> > an exception, as these are now subsumed in the change.
> >
> > Signed-off-by: Richard Henderson <address@hidden>
> > ---
> >   target-mips/translate.c | 47 +++++++++++++++++++++++------------------------
> >   1 file changed, 23 insertions(+), 24 deletions(-)
>
> Isn't that a bit redundant with the work from Pavel Dovgalyuk:
>
> https://lists.gnu.org/archive/html/qemu-devel/2015-07/msg02581.html

Yes, it is.  I'd forgotten about it.  It is interesting that he makes the 
opposite choice -- changing all of the places that unconditional exceptions are 
raised, rather than the conditional exceptions.

That said, I guess it really doesn't matter either way.


r~