Re: [Qemu-devel] [PATCHv2] sdhci: Pass drive parameter to sdhci-pci via qdev property

[Stefan Hajnoczi]

On Sun, Aug 02, 2015 at 12:44:16PM -0400, Kevin O'Connor wrote:
> Commit 19109131 disabled the sdhci-pci support because it used
> drive_get_next().  This patch reenables sdhci-pci and changes it to
> pass the drive via a qdev property - for example:
>  -device sdhci-pci,drive=drive0 -drive id=drive0,if=sd,file=myimage
> 
> Signed-off-by: Kevin O'Connor <address@hidden>
> ---
> 
> v2:
> - Don't call blk_detach_dev() in sdhci pci code - instead change
>   sd_init() to use blk_attach_dev() instead of blk_attach_dev_nofail().
> 
> ---
>  hw/sd/sd.c    |  4 +++-
>  hw/sd/sdhci.c | 32 +++++++++++++++++++-------------
>  hw/sd/sdhci.h |  2 ++
>  3 files changed, 24 insertions(+), 14 deletions(-)

Reviewed-by: Stefan Hajnoczi <address@hidden>

pgp4oluI595HN.pgp
Description: PGP signature