[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 12/26] tests/qapi-schema: Document alternate's enum
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH 12/26] tests/qapi-schema: Document alternate's enum lacks visit function |
Date: |
Tue, 4 Aug 2015 11:18:02 +0200 |
We generate a declaration, but no definition.
The QMP schema has two: Qcow2OverlapChecks and BlockdevRef. Neither
visit_type_Qcow2OverlapChecksKind() nor visit_type_BlockdevRefKind()
is actually used.
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
tests/qapi-schema/qapi-schema-test.json | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/qapi-schema/qapi-schema-test.json
b/tests/qapi-schema/qapi-schema-test.json
index ccadb13..8337ba9 100644
--- a/tests/qapi-schema/qapi-schema-test.json
+++ b/tests/qapi-schema/qapi-schema-test.json
@@ -56,6 +56,7 @@
{ 'alternate': 'UserDefAlternate',
'data': { 'uda': 'UserDefA', 's': 'str', 'i': 'int' } }
+# FIXME only a declaration of visit_type_UserDefAlternateKind() generated
{ 'struct': 'UserDefC',
'data': { 'string1': 'str', 'string2': 'str' } }
--
2.4.3
- Re: [Qemu-devel] [PATCH 16/26] qapi: Document flaws in checking of names, (continued)
- [Qemu-devel] [PATCH 17/26] tests/qapi-schema: Restore test case for flat union base bug, Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH 14/26] qapi: Document that input visitor semantics are prone to leaks, Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH 19/26] qapi-tests: New tests for union, alternate command arguments, Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH 03/26] qapi: Simplify guardname(), Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH 13/26] tests/qapi-schema: Document events with base don't work, Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH 09/26] qapi-visit: Fix generated code when schema has forward refs, Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH 06/26] qapi: Drop unused and useless parameters and variables, Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH 23/26] qapi-commands: Inline gen_marshal_output_call(), Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH 11/26] qapi-visit: Fix two name arguments passed to visitors, Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH 12/26] tests/qapi-schema: Document alternate's enum lacks visit function,
Markus Armbruster <=
- [Qemu-devel] [PATCH 22/26] qapi-commands: Fix gen_err_check(e) for e and e != 'local_err', Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH 26/26] qapi: Generated code cleanup, Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH 18/26] tests/qapi-schema: Rename tests from data- to args-, Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH 24/26] qapi-commands: Don't feed output of mcgen() to mcgen() again, Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH 21/26] qapi: Command returning anonymous type doesn't work, outlaw, Markus Armbruster, 2015/08/04