Re: [Qemu-devel] [RFC PATCH v0 3/5] spapr: Revert to address@hidden representation for non-hotplugged memory

[Bharata B Rao]

On Tue, Aug 04, 2015 at 09:33:56AM -0500, Nathan Fontenot wrote:
> On 08/03/2015 12:35 AM, Bharata B Rao wrote:
> > Don't represent non-hotluggable memory under drconf node. With this
> > we don't have to create DRC objects for them.
> > 
> > The effect of this patch is that we revert back to address@hidden 
> > representation
> > for all the memory specified with -m option and represent the cold
> > plugged memory and hot-pluggable memory under
> > ibm,dynamic-reconfiguration-memory.
> >
> 
> I was looking through this and looking at the kernel code that inits memory
> for power systems and I wanted to make sure this is really working and
> you are seeing all the memory you expect to see in the guest.
> 
> Looking through the memory init code (powerpc/kerne/prom.c) it appears that
> the additional address@hidden would get initialized very early in boot, the 
> same
> time we currently init the address@hidden node. Then later in boot we would 
> init
> the rest of memory, lmbs in the dynamic-reconfiguration property.
> 
> Just wanting to make sure I'm understanding how this is working.
> 
> Also, since the memory specified in the address@hidden nodes is not removable 
> this
> should not break any of the userspace tools.

Thanks for confirming this. Initially I went for only address@hidden and
rest of the memory as part of ibm,dynamic-reconfiguration-memory because
that's how it was in a couple of PowerVM boxes that I checked.

Regards,
Bharata.