[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] block: don't register quorum driver if SHA256 s
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH] block: don't register quorum driver if SHA256 support is unavailable |
|
Date: |
Wed, 5 Aug 2015 15:28:38 +0100 |
On 4 August 2015 at 15:48, Sascha Silbe <address@hidden> wrote:
> Commit 488981a4 [block: convert quorum blockdrv to use crypto APIs]
> broke qemu-iotest 041 on hosts with GnuTLS < 2.10.0. It converted a
> compile-time check to a run-time check at device open time. The result
> is that we now advertise a feature (the quorum block driver) that will
> never work (on those hosts). There's no way (short of parsing
> human-readable error messages) for qemu-iotests or any other API
> consumer to recognise that the quorum block driver isn't _actually_
> available and shouldn't be used or tested.
>
> Move the run-time check to bdrv_quorum_init() to avoid registering the
> quorum block driver if we know it cannot work. This way API consumers
> can recognise it's unavailable.
>
> Fixes: 488981a4af396551a3178d032cc2b41d9553ada2
> Signed-off-by: Sascha Silbe <address@hidden>
Applied to master, thanks.
-- PMM