[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC v3 10/32] qapi-types: Convert to QAPISchemaV
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH RFC v3 10/32] qapi-types: Convert to QAPISchemaVisitor, fixing flat unions |
Date: |
Wed, 5 Aug 2015 09:15:06 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 08/04/2015 09:57 AM, Markus Armbruster wrote:
> Fixes flat unions to get the base's base members. Test case is from
> commit 2fc0043, in qapi-schema-test.json:
>
>
> Flat union visitors remain broken. They'll be fixed next.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> docs/qapi-code-gen.txt | 51 +++---
Thanks for updating the docs. The diffstat of the actual generated code
is large, but the extra commits prove that in the end it's the same
material, just in different ordering. Meanwhile, the doc example is
correct, and being much shorter, makes it easier to see the sort of
reordering that happened.
> scripts/qapi-types.py | 273
> ++++++++++++++------------------
> tests/qapi-schema/qapi-schema-test.json | 4 +-
> 3 files changed, 144 insertions(+), 184 deletions(-)
>
> +
> +# If you link code generated from multiple schemata, you want only one
> +# instance include the code generated for built-in types. Generate it
s/include/of/
> +# only when do_builtins, enabled by command line option -b. See also
> +# QAPISchemaGenTypeVisitor.visit_end().
> do_builtins = False
With the grammar fix,
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH RFC v3 11/32] qapi-visit: Convert to QAPISchemaVisitor, fixing bugs, (continued)
- [Qemu-devel] [PATCH RFC v3 25/32] qapi: Improve built-in type documentation, Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH RFC v3 15/32] qapi-event: Convert to QAPISchemaVisitor, fixing data with base, Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH RFC v3 05/32] tests/qapi-schema: Convert test harness to QAPISchemaVisitor, Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH RFC v3 28/32] qapi-schema: Fix up misleading specification of netdev_add, Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH RFC v3 10/32] qapi-types: Convert to QAPISchemaVisitor, fixing flat unions, Markus Armbruster, 2015/08/04
- Re: [Qemu-devel] [PATCH RFC v3 10/32] qapi-types: Convert to QAPISchemaVisitor, fixing flat unions,
Eric Blake <=
- [Qemu-devel] [PATCH RFC v3 27/32] qom: Don't use 'gen': false for qom-get, qom-set, object-add, Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH RFC v3 31/32] qapi-introspect: Map all integer types to 'int', Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH RFC v3 20/32] qapi-visit: Rearrange code a bit, Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH RFC v3 32/32] qapi-introspect: Hide type names, Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH RFC v3 29/32] qapi: Pseudo-type '**' is now unused, drop it, Markus Armbruster, 2015/08/04