[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/2] fw_cfg: document MMIO registers for arm,
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/2] fw_cfg: document MMIO registers for arm, sun4*, and ppc/mac_* |
Date: |
Thu, 6 Aug 2015 14:15:11 +0100 |
On 6 August 2015 at 10:14, Laszlo Ersek <address@hidden> wrote:
> On 08/06/15 01:47, Gabriel L. Somlo wrote:
>> +=== arm Register Locations ===
>> +
>> +Selector Register MMIO addr: 0x9020008 (16-bit, big-endian)
>> +Data Register MMIO addr: 0x9020000 (64-bit)
>
> Suggestions:
> - maybe mention that this is specific to the "virt" machtype
> - mention that the exact location comes from the DTB,
> and hint at "Documentation/devicetree/bindings/arm/fw-cfg.txt" in the
> kernel tree
> - for the data register, rather than just "(64-bit)", consider saying
> "(64-bit, endianless, string-preserving)"
We shouldn't be documenting the specific locations at all --
the guest *must* look at the DTB or ACPI table to find the
device.
-- PMM
- [Qemu-devel] [PATCH v2 0/2] fw_cfg: documentation updates for v2.4, Gabriel L. Somlo, 2015/08/05
- [Qemu-devel] [PATCH v2 1/2] fw_cfg: document fw_cfg_modify_iXX() update functions, Gabriel L. Somlo, 2015/08/05
- [Qemu-devel] [PATCH v2 2/2] fw_cfg: document MMIO registers for arm, sun4*, and ppc/mac_*, Gabriel L. Somlo, 2015/08/05
- Re: [Qemu-devel] [PATCH v2 2/2] fw_cfg: document MMIO registers for arm, sun4*, and ppc/mac_*, Laszlo Ersek, 2015/08/06
- Re: [Qemu-devel] [PATCH v2 2/2] fw_cfg: document MMIO registers for arm, sun4*, and ppc/mac_*,
Peter Maydell <=
- Re: [Qemu-devel] [PATCH v2 2/2] fw_cfg: document MMIO registers for arm, sun4*, and ppc/mac_*, Gabriel L. Somlo, 2015/08/06
- Re: [Qemu-devel] [PATCH v2 2/2] fw_cfg: document MMIO registers for arm, sun4*, and ppc/mac_*, Peter Maydell, 2015/08/06
Re: [Qemu-devel] [PATCH v2 0/2] fw_cfg: documentation updates for v2.4, Peter Maydell, 2015/08/06