qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 1/2] make: fix where dependency *.d are store


From: Alex Bennée
Subject: Re: [Qemu-devel] [PATCH v2 1/2] make: fix where dependency *.d are stored.
Date: Thu, 06 Aug 2015 16:55:41 +0100

Michael S. Tsirkin <address@hidden> writes:

> On Thu, Aug 06, 2015 at 09:57:03AM +0100, Alex Bennée wrote:
>> 
>> Victor Kaplansky <address@hidden> writes:
>> 
<snip>
>> >
>> > As a hack, we also touch two sources for generated *.hex files. This is
>> > to ensure *.hex rebuild, when old revision is switched to the new one.
>> 
>> While I'm sure this was useful for testing do we really want to include
>> such a hack in the git history?
>
> This is the hint for why it's needed there:
> "This is to ensure *.hex rebuild, when old revision is switched to the
> new one."
> Maybe add this, making this more explicit:
>       Without this hack, anyone doing "git pull; make" will not get *.hex 
> rebuilt
>       correctly since the dependency file would be missing.

Ahh that makes more sense :-)

-- 
Alex Bennée



reply via email to

[Prev in Thread] Current Thread [Next in Thread]