[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 08/10] qcow2: Invoke refcount order amendment
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v9 08/10] qcow2: Invoke refcount order amendment function |
|
Date: |
Thu, 6 Aug 2015 21:34:52 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 08/06/2015 09:10 AM, Alberto Garcia wrote:
> On Mon 27 Jul 2015 05:51:38 PM CEST, Max Reitz wrote:
>
>> + if (refcount_bits <= 0 || refcount_bits > 64 ||
>> + !is_power_of_2(refcount_bits))
>> + {
>> + error_report("Refcount width must be a power of two and may
>> "
>> + "not exceed 64 bits");
>> + return -EINVAL;
>> + }
>
> I guess there's no lower limit needed for this? Doesn't it break
> anything if refcount_bits == 1?
refcount_bits == 1 works just fine - you have an image that can't take
internal snapshots, and has a maximally dense refblock.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature