Re: [Qemu-devel] [PATCH v8 3/5] Introduce irqchip type specification for KVM

[Peter Maydell]

On 10 August 2015 at 13:06, Pavel Fedin <address@hidden> wrote:
> This patch introduces kernel_irqchip_type member in Machine class, which
> is passed to kvm_arch_irqchip_create. Machine models which can use vGIC
> now use it in order to supply correct GIC type for KVM capability
> verification. The variable is defined as int in order to be
> architecture-agnostic for potential future uses by other architectures.
>
> Signed-off-by: Pavel Fedin <address@hidden>

I still think this is the wrong approach -- see my remarks
in the previous round of patch review.

thanks
-- PMM